Skip to content

Pin Javadoc URLs to current stable version#183

Merged
scordio merged 4 commits into
assertj:mainfrom
Madjosz:main
Feb 25, 2026
Merged

Pin Javadoc URLs to current stable version#183
scordio merged 4 commits into
assertj:mainfrom
Madjosz:main

Conversation

@Madjosz

@Madjosz Madjosz commented May 22, 2025

Copy link
Copy Markdown
Contributor

Latest JavaDoc pages include the module name in the URL.

This PR adds the module name to the URL path of :assertj-core-javadoc-root: and :assertj-guava-javadoc-root:.
Furthermore the following improvements are included:

  • link-attributes are now consistently used among AssertJ Core, AssertJ Guava, and AssertJ Joda Time
  • URLs including ... needed to be escaped
  • AssertJ DB was not touched for this PR

@Madjosz

Madjosz commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

Hi @scordio
since you seem to be an active maintainer of this repo I would be delighted if you could take a look at this PR.
Kind regards

@scordio scordio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Madjosz, thanks for the PR and the reminder, this totally slipped under my radar 🙂

Comment thread src/docs/asciidoc/link-attributes.adoc Outdated
@Madjosz Madjosz requested a review from scordio August 18, 2025 21:28
@Madjosz

Madjosz commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

@scordio I changed the things you requested. You could take a look again.

@Madjosz

Madjosz commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

@scordio Just a little reminder that this is still unmerged.

@scordio scordio changed the title Fix URLs to JavaDoc Pin Javadoc URLs to current stable version Feb 25, 2026
@scordio scordio merged commit f0cde83 into assertj:main Feb 25, 2026
2 checks passed
@scordio

scordio commented Feb 25, 2026

Copy link
Copy Markdown
Member

This is finally merged. Thanks for your contribution and patience, @Madjosz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants